Merge pull request #125518 from pohly/scheduler-perf-cleanup-fix

scheduler_perf: shut down apiserver clients before apiserver
This commit is contained in:
Kubernetes Prow Robot 2024-06-16 10:03:29 -07:00 committed by GitHub
commit 0fd6746b2a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -98,11 +98,10 @@ func mustSetupCluster(tCtx ktesting.TContext, config *config.KubeSchedulerConfig
if err != nil {
tCtx.Fatalf("start apiserver: %v", err)
}
// Cleanup will be in reverse order: first the clients by canceling the
// child context (happens automatically), then the server.
tCtx.Cleanup(server.TearDownFn)
// Cleanup will be in reverse order: first the clients get cancelled,
// then the apiserver is torn down via the automatic cancelation of
// tCtx.
tCtx = ktesting.WithCancel(tCtx)
// TODO: client connection configuration, such as QPS or Burst is configurable in theory, this could be derived from the `config`, need to
// support this when there is any testcase that depends on such configuration.