github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-06 10:43:56 +00:00
Code Issues Projects Releases Wiki Activity

Chore: remove impossible and redunant cases

Browse Source
This commit is contained in:
mowangdk 2023-04-25 10:55:12 +08:00
parent 959c90c1d9
commit 3d8f7233da
1 changed files with 0 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
staging/src/k8s.io/cloud-provider/controllers/service/controller_test.go
View File

@ -185,14 +185,6 @@ func TestSyncLoadBalancerIfNeeded(t *testing.T) {
expectOp: deleteLoadBalancer,
expectPatchStatus: false,
},
{
desc: "service no longer wants LB",
service: newService("no-external-balancer", v1.ServiceTypeClusterIP, tweakAddLBIngress("8.8.8.8")),
lbExists: true,
expectOp: deleteLoadBalancer,
expectDeleteAttempt: true,
expectPatchStatus: true,
},
{
desc: "udp service that wants LB",
service: newService("udp-service", v1.ServiceTypeLoadBalancer, tweakAddPorts(v1.ProtocolUDP, 0)),
@ -225,14 +217,6 @@ func TestSyncLoadBalancerIfNeeded(t *testing.T) {
expectPatchStatus: false,
expectPatchFinalizer: false,
},
{
desc: "service doesn't specify loadBalancerClass",
service: newService("with-external-balancer", v1.ServiceTypeLoadBalancer, tweakAddLBClass(nil), tweakAddPorts(v1.ProtocolSCTP, 0)),
expectOp: ensureLoadBalancer,
expectCreateAttempt: true,
expectPatchStatus: true,
expectPatchFinalizer: true,
},
// Finalizer test cases below.
{
desc: "service with finalizer that no longer wants LB",
@ -252,14 +236,6 @@ func TestSyncLoadBalancerIfNeeded(t *testing.T) {
expectPatchStatus: true,
expectPatchFinalizer: true,
},
{
desc: "service without finalizer that wants LB",
service: newService("basic-service1", v1.ServiceTypeLoadBalancer, tweakAddPorts(v1.ProtocolTCP, 0)),
expectOp: ensureLoadBalancer,
expectCreateAttempt: true,
expectPatchStatus: true,
expectPatchFinalizer: true,
},
{
desc: "service with finalizer that wants LB",
service: newService("basic-service1", v1.ServiceTypeLoadBalancer, tweakAddPorts(v1.ProtocolTCP, 0), tweakAddFinalizers(servicehelper.LoadBalancerCleanupFinalizer)),