github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-19 18:02:01 +00:00
Code Issues Projects Releases Wiki Activity

Revert "use uncommon ports for e2e network test"

Browse Source 
This reverts commit be1ed2f43a.

The problem happens when the pod tries to be scheduled, not the
service. Also, maybe skipping is not the best idea ...
This commit is contained in:
Antonio Ojea 2020-12-14 08:56:16 +01:00
parent 87984d84d1
commit 638da25dd1
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/e2e/framework/network/utils.go
View File

@ -715,13 +715,6 @@ func (config *NetworkingTestConfig) CreateService(serviceSpec *v1.Service) *v1.S
framework.ExpectNoError(err, fmt.Sprintf("Failed to create %s service: %v", serviceSpec.Name, err))
err = WaitForService(config.f.ClientSet, config.Namespace, serviceSpec.Name, true, 5*time.Second, 45*time.Second)
// If the endpoints of the service use HostNetwork: true, they are going to try to bind on the host namespace
// if those ports are in use by any process in the host, the endpoints pods will fail to be deployed
// and the service will never be ready. We can be smarter and check directly that the ports are free
// but by now we Skip the test if the service is not ready and we are using endpoints with host network
if config.EndpointsHostNetwork && err != nil {
e2eskipper.Skipf("Service not ready. Pods are using hostNetwork: true, please check there is no other process on the host using the same ports: %v", err)
}
framework.ExpectNoError(err, fmt.Sprintf("error while waiting for service:%s err: %v", serviceSpec.Name, err))
createdService, err := config.getServiceClient().Get(context.TODO(), serviceSpec.Name, metav1.GetOptions{})