github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-31 07:20:13 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #104435 from liggitt/convertible-test

Browse Source 
Fix slice type comparison bug
This commit is contained in:
Kubernetes Prow Robot 2021-08-20 12:38:47 -07:00 committed by GitHub
commit 7652353523
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
plugin/pkg/admission/serviceaccount/admission_test.go
View File

@ -747,6 +747,11 @@ func TestAddImagePullSecrets(t *testing.T) {
{Name: "bar"},
},
}
originalSA := sa.DeepCopy()
expected := []api.LocalObjectReference{
{Name: "foo"},
{Name: "bar"},
}
// Add the default service account for the ns with a secret reference into the cache
informerFactory.Core().V1().ServiceAccounts().Informer().GetStore().Add(sa)
@ -757,10 +762,10 @@ func TestAddImagePullSecrets(t *testing.T) {
t.Errorf("Unexpected error: %v", err)
}
assert.EqualValues(t, sa.ImagePullSecrets, pod.Spec.ImagePullSecrets, "expected %v, got %v", sa.ImagePullSecrets, pod.Spec.ImagePullSecrets)
assert.EqualValues(t, expected, pod.Spec.ImagePullSecrets, "expected %v, got %v", expected, pod.Spec.ImagePullSecrets)
pod.Spec.ImagePullSecrets[1] = api.LocalObjectReference{Name: "baz"}
if reflect.DeepEqual(sa.ImagePullSecrets, pod.Spec.ImagePullSecrets) {
if !reflect.DeepEqual(originalSA, sa) {
t.Errorf("accidentally mutated the ServiceAccount.ImagePullSecrets: %v", sa.ImagePullSecrets)
}
}