Aaron Crickenberger
357ad91d78
demote kubelet events test from Conformance
...
This test has been part of the Conformance suite since at least
Kubernetes 1.2 (2015-10-xx). Some years later, around 2018-10-xx, we
drafted a rigorous set of rules for tests to follow in order to be
eligible for promotion to Conformance. We explicitly disallowed any
tests that check for specific Events, since they are not an API, and we
make no guarantees about their contents nor their delivery.
Unfortunately, we neglected to go through the existing corpus of
Conformance tests with a fine-toothed comb after drafting these rules.
The very nature of what this test is attempting to exercise and verify
is specific Events, and their delivery, thus making it ineligible for
Conformance. We should have caught and demoted this test back then.
Better late than never?
2021-11-17 15:36:30 -08:00
Anago GCB
7f756417ff
Merge remote-tracking branch 'origin/master'
2021-11-17 21:45:30 +00:00
Anago GCB
ab3f2bd0a9
Merge remote-tracking branch 'origin/master'
2021-11-17 21:41:42 +00:00
Anago GCB
a111de7e50
Merge remote-tracking branch 'origin/master'
2021-11-17 21:40:53 +00:00
Anago GCB
8c7ecd9fc0
Merge remote-tracking branch 'origin/master'
2021-11-17 21:33:29 +00:00
Kubernetes Prow Robot
e4952f32b7
Merge pull request #106463 from SergeyKanzhelev/grpcProbe
...
Implement grpc probe action
2021-11-17 12:43:54 -08:00
Anago GCB
b9884355ff
CHANGELOG: Update directory for v1.23.0-beta.0 release
2021-11-17 20:16:04 +00:00
Sergey Kanzhelev
b7affcced1
implement :grpc probe action
2021-11-17 17:31:23 +00:00
Kubernetes Prow Robot
1367cca8fd
Merge pull request #106448 from aojea/hlee/issue-103721/staticcheck
...
use golangci-lint
2021-11-17 09:25:54 -08:00
Anago GCB
5cf7e5f57d
CHANGELOG: Update directory for v1.22.4 release
2021-11-17 16:31:05 +00:00
Kubernetes Prow Robot
cd6ffff85d
Merge pull request #103526 from brianpursley/kubectl-686
...
Close connection and stop listening when port forwarding errors occur so that kubectl can exit
2021-11-17 07:59:54 -08:00
Anago GCB
9237f5d16c
CHANGELOG: Update directory for v1.21.7 release
2021-11-17 15:22:27 +00:00
Anago GCB
6e4534f584
CHANGELOG: Update directory for v1.20.13 release
2021-11-17 13:38:03 +00:00
Kubernetes Prow Robot
557b5feb08
Merge pull request #106305 from shivanshu1333/fix/master/schedularMigration
...
migrated schedular to structured logging
2021-11-17 05:05:54 -08:00
Antonio Ojea
bf9ce7fd76
remove unused fakeUpgradeConnection
2021-11-17 13:58:54 +01:00
Antonio Ojea
9336ff78f4
remove unused variable responseBodySize
2021-11-17 13:58:54 +01:00
Antonio Ojea
3490bdc8b5
remove unused listMetaType var
2021-11-17 13:58:54 +01:00
Antonio Ojea
98884f733a
remove ineffectual assignment base var
2021-11-17 13:58:54 +01:00
Antonio Ojea
f143d1b2cd
remove unused constant errLeaseFailed
2021-11-17 13:58:54 +01:00
Antonio Ojea
05f9a86f41
fix diskName assignment
2021-11-17 13:58:54 +01:00
Antonio Ojea
e1821c13eb
remove inefficient assignment
2021-11-17 13:58:54 +01:00
Antonio Ojea
0019f98613
no lint unused variables
2021-11-17 13:58:54 +01:00
Antonio Ojea
e82e0b38ff
no lint unused variables
2021-11-17 13:58:54 +01:00
Antonio Ojea
4352768240
fix inefassign linter declaring variable
2021-11-17 13:58:54 +01:00
Antonio Ojea
4bf93f318a
nolint:staticcheck,ineffassign Convert function
2021-11-17 13:58:54 +01:00
Antonio Ojea
35c05a3afa
nolint float64(-0.0), //nolint:staticcheck // SA4026:
2021-11-17 13:58:54 +01:00
Antonio Ojea
c4080c2ad1
nolint unused expectNoMatchDirect function
2021-11-17 13:58:54 +01:00
Antonio Ojea
52c69ba744
fix ineffectual assignment to name (ineffassign)
2021-11-17 13:58:54 +01:00
Antonio Ojea
31d45d000b
fix ineffectual assignment to base var
2021-11-17 13:58:53 +01:00
Antonio Ojea
b2971e7497
fix ineffectual assignment to i (ineffassign)
2021-11-17 13:58:53 +01:00
Antonio Ojea
a36517f9e7
nolint unused errLeaseFailed
2021-11-17 13:58:53 +01:00
Antonio Ojea
d55af19c1b
fix ineffectual assignment to diskName
2021-11-17 13:58:53 +01:00
Antonio Ojea
fa3c4b953f
fix SA4005: ineffective assignment to field PatchMeta.patchStrategies (staticcheck)
2021-11-17 13:58:53 +01:00
Antonio Ojea
01a0fba362
fix unassigned error on client-go test
2021-11-17 13:58:53 +01:00
Antonio Ojea
d126b14838
migrate nolint coments to golangci-lint
2021-11-17 13:58:53 +01:00
Antonio Ojea
272b31da50
use golangci-lint and remove legacy verify-staticcheck.sh
2021-11-17 13:58:53 +01:00
Antonio Ojea
86e197991a
fix golangci-lint config file using exclude-rules
...
golangci configuration file
disable soon to be deprecated golangci linters
remove useless comments on golangci config
2021-11-17 13:58:53 +01:00
Hanna Lee
ca7cfb75d0
Copy in options from now-deleted hack/verify-staticcheck.sh script
2021-11-17 08:56:57 +01:00
Tim Hockin
e986d72575
Add staticcheck to .golangci.yaml
...
TODO: port options from verify-staticcheck.sh and delete it
2021-11-17 08:56:57 +01:00
Tim Hockin
3bca4e6d67
Move golangci-lint config to a file
...
Make verify-golangci-lint.sh work across modules and take an optional
argument for a package.
2021-11-17 08:56:57 +01:00
Hanna Lee
e78b3e8dfe
Use nolint directive instead of stopping ticker, per liggit's suggestion
2021-11-17 08:56:57 +01:00
Hanna Lee
69d029bddb
Add syncTicker.Stop()
2021-11-17 08:56:57 +01:00
Hanna Lee
07a883d8e6
Remove //lint:ignore pragmas that aren't being used anymore
2021-11-17 08:56:54 +01:00
Hanna Lee
a707061828
Simplify multiplication
2021-11-17 08:56:02 +01:00
Hanna Lee
2933df3645
Fix order of operations
2021-11-17 08:56:02 +01:00
Hanna Lee
c8fde197f5
Add more //nolint:staticcheck for failures caught in PR tests
2021-11-17 08:56:02 +01:00
Hanna Lee
c862d7c0e9
Fix last remaining SA5011 error by removing unnecessary r != nil check
2021-11-17 08:56:01 +01:00
Hanna Lee
a7daeb37af
Convert one more utilflag.IPVar to &utilflag.IPVar
2021-11-17 08:56:01 +01:00
Hanna Lee
7ea01c0bdb
Add staticcheck to verify-golangci-lint.sh
2021-11-17 08:56:01 +01:00
Hanna Lee
04fadd8b03
Fix SA5011 errors by making control flow abort obvious to linter
2021-11-17 08:56:00 +01:00
