github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-19 08:40:42 +00:00
Code Issues Projects Releases Wiki Activity
128,038 Commits 42 Branches 8,000 Tags 1.3 GiB
3b7926824e
Commit Graph

128038 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rodrigo Campos
3b7926824e e2e_node: Don't use userns in DefaultPocMount tests 
When proc mount is set to default, it should mask /proc.

The DefaultProcMount test was setting "hostUsers: false" which means to
create a user namespaces. This was not causing issues before, because
user namespaces was disabled by default and therefore the field was
completely ignored. Now that userns is enabled by default, the test is
failing as the runtime doesn't always have userns support.

One option would be to filter for runtimes that do have userns support.
But the default case (/proc is masked) for sure we want to test it
without userns support, as it will be applied to all pods.

To that end, we add a param "hostUsers bool" to testProcMount that will
enable it or not. Then, both test cases that call this function set it
accordingly: the default case sets it to true (no user namespace), and
the unmasked case with a privileged pod sets it to false (use a user
namespace), to verify the /proc mount is unmasked in this case.

Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
 2025-02-17 11:51:55 +01:00
Rodrigo Campos
3725c6f765 pkg/kubelet: Make newTestKubeletWithImageList allocate a userns manager 
When switching the feature flag to on by default, this test was failing:

	I0213 14:42:45.311186  341895 factory.go:193] Registered Plugin "containerd"
	I0213 14:42:45.315673  341895 plugins.go:615] "Loaded volume plugin" pluginName="fake"
	I0213 14:42:45.315750  341895 kubelet_pods.go:1165] "Clean up pod workers for terminated pods"
	I0213 14:42:45.315759  341895 kubelet_pods.go:1215] "Clean up probes for terminated pods"
	I0213 14:42:45.315764  341895 kubelet_pods.go:1219] "Clean up orphaned pod statuses"
	I0213 14:42:45.315768  341895 kubelet_pods.go:1223] "Clean up orphaned pod user namespace allocations"
	--- FAIL: TestKubelet_HandlePodCleanups (0.00s)
	    --- FAIL: TestKubelet_HandlePodCleanups/missing_pod_is_requested_for_termination_with_short_grace_period (0.00s)
	panic: runtime error: invalid memory address or nil pointer dereference [recovered]
		panic: runtime error: invalid memory address or nil pointer dereference
	[signal SIGSEGV: segmentation violation code=0x1 addr=0x38 pc=0x2b14d7e]

	goroutine 142 [running]:
	testing.tRunner.func1.2({0x30b5260, 0x5cfa1e0})
		/usr/lib/go-1.23/src/testing/testing.go:1632 +0x230
	testing.tRunner.func1()
		/usr/lib/go-1.23/src/testing/testing.go:1635 +0x35e
	panic({0x30b5260?, 0x5cfa1e0?})
		/usr/lib/go-1.23/src/runtime/panic.go:785 +0x132
	k8s.io/kubernetes/pkg/kubelet/userns.(*UsernsManager).CleanupOrphanedPodUsernsAllocations(0x0, {0x5d90f80, 0x0, 0x0?}, {0xc0006a1d50, 0x1, 0x0?})
		/home/rodrigo/src/kinvolk/kubernetes/kubernetes/pkg/kubelet/userns/userns_manager.go:474 +0x9e
	k8s.io/kubernetes/pkg/kubelet.(*Kubelet).HandlePodCleanups(0xc00067c808, {0x3b876b0, 0x5d90f80})
		/home/rodrigo/src/kinvolk/kubernetes/kubernetes/pkg/kubelet/kubelet_pods.go:1224 +0x618
	k8s.io/kubernetes/pkg/kubelet.TestKubelet_HandlePodCleanups.func35(0xc0001349c0)
		/home/rodrigo/src/kinvolk/kubernetes/kubernetes/pkg/kubelet/kubelet_pods_test.go:6415 +0x72d
	testing.tRunner(0xc0001349c0, 0xc0009801b0)
		/usr/lib/go-1.23/src/testing/testing.go:1690 +0xf4
	created by testing.(*T).Run in goroutine 141
		/usr/lib/go-1.23/src/testing/testing.go:1743 +0x390
	exit status 2
	FAIL	k8s.io/kubernetes/pkg/kubelet	0.029s

The issue is that no userns manager is allocated in the FakeKubelet.
Let's allocate one.

Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
 2025-02-13 15:00:07 +01:00
Rodrigo Campos
96c2b81670 features: Enable user namespaces by default 
The feature gate UserNamespacesSupport is enabled by default now
(KEP 127): https://github.com/kubernetes/enhancements/pull/5118.

Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
 2025-02-13 15:00:07 +01:00
Kubernetes Prow Robot
e62ce1c9db
Merge pull request #129489 from elizabeth-dev/replace-network-e2e-replicationcontrollers 
test(network): replace jig.CreateRC with jig.CreateDeployment
 2025-02-13 05:58:22 -08:00
Elizabeth Martin Campos
4724870b97
test: remove implicit inclusion of "name" label in utils functions 2025-02-13 12:48:30 +01:00
Kubernetes Release Robot
2642d8222d CHANGELOG: Update directory for v1.32.2 release 2025-02-13 09:39:00 +00:00
Kubernetes Release Robot
976eae5ee7 CHANGELOG: Update directory for v1.31.6 release 2025-02-13 08:29:30 +00:00
Kubernetes Release Robot
fc219cd384 CHANGELOG: Update directory for v1.29.14 release 2025-02-13 08:29:18 +00:00
Kubernetes Release Robot
08ea6ca8da CHANGELOG: Update directory for v1.30.10 release 2025-02-13 08:26:27 +00:00
Kubernetes Prow Robot
11ec99f7ff
Merge pull request #130127 from carlory/fix-metrics 
GetRandomReadySchedulableNode does not return MetricsGrabbingDisabledError
 2025-02-13 00:12:20 -08:00
Kubernetes Prow Robot
ea50baedcd
Merge pull request #129875 from pohly/golangci-lint-strict-removal 
golangci-lint: remove "strict" checking
 2025-02-12 20:26:20 -08:00
carlory
93a88f5518 GetRandomReadySchedulableNode nerver return MetricsGrabbingDisabledError 
Signed-off-by: carlory <baofa.fan@daocloud.io>
 2025-02-13 12:00:42 +08:00
Kubernetes Prow Robot
215a9101a7
Merge pull request #130123 from marosset/windows-unit-test-skip-ippvs-test-cases 
skipping InPlacePodVerticleScaling unit tests on Windows
 2025-02-12 17:10:20 -08:00
Mark Rossetti
df1e9eeeb8
skipping InPlacePodVerticleScaling unit tests on Windows 
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
 2025-02-12 15:57:20 -08:00
Kubernetes Prow Robot
d7db75ce91
Merge pull request #130039 from p0lyn0mial/upstream-fake-client-improve-unit-test 
fake/clientset: improve TestNewSimpleClientset
 2025-02-12 15:16:27 -08:00
Kubernetes Prow Robot
f38fca82dc
Merge pull request #130024 from sivchari/propagate-context 
Propagate cotnext to avoid goroutine leak
 2025-02-12 15:16:19 -08:00
Kubernetes Prow Robot
fbdf8905ea
Merge pull request #130058 from gjkim42/add-disableLegacySidecarContainers 
Add LegacySidecarContainers feature gate
 2025-02-12 13:16:27 -08:00
Kubernetes Prow Robot
5d57d0c110
Merge pull request #129845 from bitoku/fix-flake 
Reduce the number of processes used in e2e to prevent unexpected OOM
 2025-02-12 13:16:20 -08:00
Kubernetes Prow Robot
5e1c31b9db
Merge pull request #130053 from iholder101/bugfix/swap-resource-metrics-e2e-bug 
[KEP-2400] [failing-test] resource metrics e2e tests: expect swap node and container level stats
 2025-02-12 12:02:28 -08:00
Kubernetes Prow Robot
cd2959b798
Merge pull request #127525 from scott-grimes/patch-1 
fix: pods meeting qualifications for static placement when cpu-manager-policy=static should not have cfs quota enforcement
 2025-02-12 12:02:21 -08:00
Kubernetes Prow Robot
be80fec686
Merge pull request #130102 from marosset/bump-windows-pause-image-base 
Bump windows pause image base to mcr.microsoft.com/oss/kubernetes/windows-pause-image-base:v0.4.1
 2025-02-12 10:48:27 -08:00
Kubernetes Prow Robot
f77a1728be
Merge pull request #130009 from kannon92/fix-runtime-class-flake 
aim to fix runtime class error
 2025-02-12 10:48:20 -08:00
Ayato Tokubi
dbb34a04cc Reduce the number of processes used in e2e to prevent unexpected OOM 
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
 2025-02-12 17:39:56 +00:00
Kubernetes Prow Robot
75909b8920
Merge pull request #130113 from AwesomePatrol/129931-fix-3 
Make ResourceQuota LIST requests only when Informer is not synced
 2025-02-12 07:24:06 -08:00
Kubernetes Prow Robot
a62752db51
Merge pull request #130110 from neolit123/1.33-remove-from-test-owners 
sig-cl: update owners for 1.33
 2025-02-12 05:22:06 -08:00
Aleksander Mistewicz
b346ac0f8e Limit ResourceQuota LIST requests to times when informer is not synced 
This should reduce the number of slow (100ms) LIST requests when there
are no ResourceQuota objects present in the namespace. The behavior
stays virtually the same.
 2025-02-12 13:46:09 +01:00
Kubernetes Prow Robot
48812f0fc4
Merge pull request #130106 from cpanato/update-rules 
update publishing rules to use go1.22.12 for some active release branches
 2025-02-12 04:00:07 -08:00
Gunju Kim
f2f4634bd3 Add LegacySidecarContainers feature gate 
This adds LegacySidecarContainers feature gate that enables the legacy
code path that predates the SidecarContainers feature to safely remove
the code.

This temporary feature gate is disabled by default, only available in
v1.33, and will be removed in v1.34.
 2025-02-12 20:15:49 +09:00
Lubomir I. Ivanov
54e2416210 update sig cl owners in k/k 2025-02-12 11:04:11 +02:00
cpanato
358afb38f5
update publishing rules to use go1.22.12 for some active release branches 
Signed-off-by: cpanato <ctadeu@gmail.com>
 2025-02-11 23:19:45 -06:00
Mark Rossetti
26fe80855d
Update build/pause/Makefile 
pin windows-pause-image-base to specific manifest digest

Co-authored-by: Benjamin Elder <bentheelder@google.com>
 2025-02-11 16:55:05 -08:00
Mark Rossett
faa23642f5
Bump windows pause image base to mcr.microsoft.com/oss/kubernetes/windows-pause-image-base:v0.4.1 
Signed-off-by: Mark Rossett <marosset@microsoft.com>
 2025-02-11 15:47:20 -08:00
Kubernetes Prow Robot
9a9f10bc7b
Merge pull request #130038 from jsafrane/selinux-controller-e2e-debian 
selinux e2e: Add support for Debian and Ubuntu
 2025-02-11 13:39:58 -08:00
Kubernetes Prow Robot
c81431de59
Merge pull request #129477 from felipeagger/feat/improve-alloc-res-ckpt 
[FG:InPlacePodVerticalScaling] Improve allocated resources checkpointing
 2025-02-11 12:06:10 -08:00
Arda Güçlü
c7a90b670c
Introduce kuberc as new flag to customize defaulting and define aliases in kubectl (#125230) 2025-02-11 12:05:58 -08:00
Kevin Hannon
f75965e5d9 aim to fix runtime class error 2025-02-11 13:54:39 -05:00
Scott Grimes
1c5170ff52 disable cfs quota when exclusive cpus allocated per static cpu policy requirements 2025-02-11 13:42:30 -05:00
Scott Grimes
437cd38e19 add feature gate 
Co-authored-by: Francesco Romani <fromani@redhat.com>
 2025-02-11 13:42:22 -05:00
Kubernetes Prow Robot
3d342e9b74
Merge pull request #130067 from kerthcet/fix/readyz 
Update the error log
 2025-02-11 07:48:07 -08:00
Kubernetes Prow Robot
e30c8a3dde
Merge pull request #130040 from HirazawaUi/make-error-consistent 
kubeadm: make kubeadm init and join output the same error
 2025-02-11 07:47:58 -08:00
Kubernetes Prow Robot
77d7f63800
Merge pull request #130074 from cpanato/update-123-main 
[go] Bump images, dependencies and versions to go 1.23.6 and distroless iptables
 2025-02-11 06:30:06 -08:00
Kubernetes Prow Robot
7a8a4c201a
Merge pull request #129933 from serathius/deprecate-namespace-index 
Disable StorageNamespaceIndex feature gate when BtreeWatchCache enabled and deprecate it
 2025-02-11 06:29:59 -08:00
HirazawaUi
ab02cda168 make error consistent 2025-02-11 21:21:10 +08:00
Itamar Holder
8a797e42e1 resource metrics e2e tests: expect swap node and container level stats 
Signed-off-by: Itamar Holder <iholder@redhat.com>
 2025-02-11 15:19:45 +02:00
Kubernetes Prow Robot
e0b17379aa
Merge pull request #130072 from Jefftree/update-oapi-fix 
Remove feature disablement ConsistentListFromCache in update openapi
 2025-02-11 05:03:58 -08:00
kerthcet
676116359d Scheduler: update the error log 
Signed-off-by: kerthcet <kerthcet@gmail.com>
 2025-02-11 20:48:37 +08:00
Kubernetes Prow Robot
670b98bf92
Merge pull request #130049 from aojea/avoid_ginkgo_dep 
reduce dependencies in apimachinery net testing utils
 2025-02-11 03:32:00 -08:00
Elizabeth Martin Campos
464fd0765d
test(network): replace jig.CreateRC with jig.CreateDeployment 
See #119021
 2025-02-11 10:35:56 +01:00
Kubernetes Prow Robot
4ee8f3cbfe
Merge pull request #130091 from googs1025/fix/preemption_log 
chore(scheduler): add more log info when no preemption candidates is found in preemption
 2025-02-11 01:22:09 -08:00
Kubernetes Prow Robot
3e4e2437e4
Merge pull request #130045 from carlory/kubeadm-exec-check 
kubeadm: update preflight check
 2025-02-11 01:21:57 -08:00