core[patch]: check before removing tags (#31691)

This commit is contained in:
Bagatur 2025-06-20 14:46:50 -07:00 committed by GitHub
parent 39a8a1121a
commit 5271fd76f1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -1069,8 +1069,10 @@ class BaseCallbackManager(CallbackManagerMixin):
tags (list[str]): The tags to remove.
"""
for tag in tags:
self.tags.remove(tag)
self.inheritable_tags.remove(tag)
if tag in self.tags:
self.tags.remove(tag)
if tag in self.inheritable_tags:
self.inheritable_tags.remove(tag)
def add_metadata(
self,
@ -1094,8 +1096,8 @@ class BaseCallbackManager(CallbackManagerMixin):
keys (list[str]): The keys to remove.
"""
for key in keys:
self.metadata.pop(key)
self.inheritable_metadata.pop(key)
self.metadata.pop(key, None)
self.inheritable_metadata.pop(key, None)
Callbacks = Optional[Union[list[BaseCallbackHandler], BaseCallbackManager]]