github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2026-07-12 19:31:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): drop unused type: ignore comments in lifecycle tests

Browse Source 
mypy flags the `# type: ignore[override]` on the test subclasses'
`close()` / `aclose()` methods as unused — `BaseChatModel.close` /
`aclose` are concrete (non-abstract) defaults, so overriding them in a
subclass does not need an override suppression.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bagatur
2026-05-27 16:42:07 -04:00
parent 9636d899ea
commit e92994f973
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libs/core/tests/unit_tests/language_models/chat_models/test_base.py
View File

@@ -1622,7 +1622,7 @@ async def test_base_aclose_default_dispatches_to_close() -> None:
closed: list[bool] = []
class _SyncOnly(FakeListChatModel):
def close(self) -> None: # type: ignore[override]
def close(self) -> None:
closed.append(True)
model = _SyncOnly(responses=["x"])
@@ -1634,7 +1634,7 @@ def test_base_context_manager_calls_close() -> None:
closed = []
class _Closeable(FakeListChatModel):
def close(self) -> None: # type: ignore[override]
def close(self) -> None:
closed.append(True)
with _Closeable(responses=["x"]) as model:
@@ -1646,7 +1646,7 @@ async def test_base_async_context_manager_calls_aclose() -> None:
closed = []
class _AsyncCloseable(FakeListChatModel):
async def aclose(self) -> None: # type: ignore[override]
async def aclose(self) -> None:
closed.append("async")
async with _AsyncCloseable(responses=["x"]) as model: