github/sparrow-kata-full
1
0
Fork 0
mirror of https://github.com/AmbiML/sparrow-kata-full.git synced 2025-07-31 05:30:34 +00:00
Code Issues Projects Releases Wiki Activity

Revert "Revert "Enables UART tx_watermark interrupts""

Browse Source 
This reverts commit 342e260470ba0c194c7f7a0d1006b2f3a2432236.

Reason for revert: adding to same topic as a sim.mk change that runs the same Renode.exe built by "m renode"

Change-Id: I4ad8715e09ec3c0bf56939706a19db9085f806bb
GitOrigin-RevId: 31b22501c04e525394bc43406affb1c4d4829c1f
This commit is contained in:
Matt Harvey 2021-08-23 22:32:58 +00:00 committed by Sam Leffler
parent cbfec8e9b7
commit 3fe3225b1f
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
apps/system/components/OpenTitanUARTDriver/src/driver.c
View File

@ -163,12 +163,7 @@ void pre_init() {
// Enables interrupts.
REG(INTR_ENABLE) = (
// TODO(mattharvey): Enable tx_watermark. Currently the handler fires
// repeatedly in a loop when doing this, even while the TX FIFO remains
// empty, contrary to the "edge triggered events" working in the OpenTitan
// docs. Check that Renode is doing the right thing and if so debug after
// re-enabling this.
// BIT(UART_INTR_COMMON_TX_WATERMARK) |
BIT(UART_INTR_COMMON_TX_WATERMARK) |
BIT(UART_INTR_COMMON_RX_WATERMARK) | BIT(UART_INTR_COMMON_TX_EMPTY));
}
@ -239,9 +234,6 @@ void tx_update(uint32_t num_valid_dataport_bytes) {
// These happen when the transmit FIFO is half-empty. This refills the FIFO to
// prevent stalling, stopping early if tx_buf becomes empty, and then signals
// any tx_update that might be waiting for tx_buf to not be full.
//
// Currently this is not actually enabled. See the TODO in the implementation of
// pre_init.
void tx_watermark_handle(void) {
fill_tx_fifo();